CVS update: samba/source/rpc_parse

[Andrew Bartlett]

tridge at samba.org wrote:
> 
> Date:   Sun Nov  4 10:13:34 2001
> Author: tridge
> 
> Update of /home/cvs/samba/source/rpc_parse
> In directory va:/tmp/cvs-serv18483
> 
> Modified Files:
>         parse_net.c
> Log Message:
> get the string lengths right in domain logons
> 
> Andrew, this fixes domain logons in head. Please look at the change,
> as I think you may have misunderstood the max_str_len field (which is
> badly named)
> 
> Revisions:
> parse_net.c             1.73 => 1.74
>         http://www.samba.org/cgi-bin/cvsweb/samba/source/rpc_parse/parse_net.c?r1=1.73&r2=1.74

Interesting notes:

That was hardcoded as 24 (for both lines) on previous versions of samba,
and at sizeof(nt_owf)/sizeof(lm_owf) over in TNG.

Also, the lengths here are user-supplied, so we probably need some
bounds checking on that.  Have you checked this for the
NTLMv2/no-LM/no-NT situations?

Other than that, I really don't understand this RPC stuff, and will be
staying as far clear as I possibly can.

Andrew Bartlett

-- 
Andrew Bartlett                                 abartlet at pcug.org.au
Samba Team member, Build Farm maintainer        abartlet at samba.org
Student Network Administrator, Hawker College   abartlet at hawkerc.net
http://samba.org     http://build.samba.org     http://hawkerc.net