CVS update: samba/source/smbd

[Jeremy Allison]

On Sat, Nov 03, 2001 at 02:07:16PM +1100, Andrew Bartlett wrote:
> Jeremy Allison wrote:
> > 
> > Date:   Fri Nov  2 18:00:49 2001
> > Author: jra
> > 
> > Update of /data/cvs/samba/source/smbd
> > In directory va:/tmp/cvs-serv27527/smbd
> > 
> > Modified Files:
> >       Tag: SAMBA_2_2
> >         password.c reply.c uid.c
> > Log Message:
> > Added extra group info into 2.2.3.
> > Jeremy.
> 
> Is this the right way to do things? 

Yes, I think so.

> What happens if the remote group
> can't be represented as a local gid_t?

Then it is ignored when the calculation is done to create a gid_t.

> I think we should do it both ways:  Use the local groups where they are
> available (becouse there may well be local file premissions associated
> with them) but also store them in the NT_USER_TOKEN no matter what -
> becouse many sites run security=domain but without winbind, and they
> will still have this problem.

I don't think so. You end up with a disconnect between
the group lists associated with the uid_t and the group lists
in the token. This isn't a good idea (IMHO).

Jeremy.