CVS update: samba/source/rpc_parse
Tim Potter
tpot at samba.org
Thu May 10 09:19:01 EST 2001
Jeremy Allison writes:
> > Modified Files:
> > parse_samr.c
> > Log Message:
> > So the samr_io_userinfo_ctr was requiring a SAM_USERINFO_CTR to be passed
> > in as well as tallocating space for one itself. I've deleted code so the
> > passed in container is used to store the SAM user info. This may have
> > broken some server side SAM stuff which probably isn't used anyway. )-:
>
> Ah bum. I'd rather you deleted the passed in version, so
> that it's *always* alloced. That makes for much cleaner
> code.
I guess that does make sense. If we're allocating stuff we might
as well allocate everything. The original code did both - you
had to pass something in, which was ignored, and you were passed
back some allocated memory.
I think I'll change it around to allocate everything.
Tim.
More information about the samba-cvs
mailing list