CVS update: samba/source/rpc_parse

[Jean Francois Micouleau]

On Wed, 9 May 2001, Jeremy Allison wrote:

> Tim Potter wrote:
> > 
> > Date:   Tuesday May 8, 2001 @ 22:05
> > Author: tpot
> > 
> > Update of /data/cvs/samba/source/rpc_parse
> > In directory va:/tmp/cvs-serv29186
> > 
> > Modified Files:
> >         parse_samr.c
> > Log Message:
> > So the samr_io_userinfo_ctr was requiring a SAM_USERINFO_CTR to be passed
> > in as well as tallocating space for one itself.  I've deleted code so the
> > passed in container is used to store the SAM user info.  This may have
> > broken some server side SAM stuff which probably isn't used anyway.  )-:
> 
> Ah bum. I'd rather you deleted the passed in version, so
> that it's *always* alloced. That makes for much cleaner
> code.

wrong too. on marshalling that's the passed version the valid one.
on unmarshalling you should allocate before unmarshalling and return that
one.

I sent a mail to tpot in private this morning to tell him already :-)

Jeremy, that's exactly the same thing as I asked you on monday evening.

	J.F.