CVS update: samba/source/include

[Jeremy Allison]

Andrew Tridgell wrote:
> 
> > Log Message:
> > Fix memory leak when doing DLIST_REMOVE(list,list).
> > Jeremy.
> 
> hmmm, that's interesting, as far as I can tell that can only happen if
> the head of the list is in the list twice. What list did this happen
> with?
> 
> The fix is OK, but I'm concerned about us having lists with duplicate
> elements. I didn't think we had any.

No we didn't. In using dlist heavily in the acl code I had
cases where I wanted to be able to call dlist_remove on an
element that may not have been in the list. I fixed dlist_remove
to allow this to work. Then jht noticed that the dlist remove
in lib/interface.c was core dumping, so I fixed that and noticed
a mem leak - hence the final (ok) fix.

Jeremy.

-- 
--------------------------------------------------------
Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.
--------------------------------------------------------