CVS update: samba/source/rpc_parse

jreilly at samba.org jreilly at samba.org
Sat Jul 28 08:38:03 EST 2001


Date:	Fri Jul 27 15:38:02 2001
Author:	jreilly

Update of /data/cvs/samba/source/rpc_parse
In directory va:/tmp/cvs-serv5842/rpc_parse

Modified Files:
      Tag: APPLIANCE_HEAD
	parse_spoolss.c 
Log Message:
Fix for determining the correct 'cversion' for a printer driver. This was
causing Win2K (and likely XP) to put some printer drivers in to the wrong
directory (e.g. print$/W32X86/2 vs print$/W32X86/3).

printing/nt_printing:
get_file_version()       Moved forward in file to remove forward reference
file_version_is_newer()  Moved forward in file to remove forward reference
get_correct_cversion()   Use get_file_version() to access the correct info
                         and got rid of 40+ lines of code

Thanks to Jim Vopni (who also had a patch!) and several others who pointed
this out.
---

Fix printer driver initialization, woo hoo! See inline comments... yes, its
there.

include/proto.h:               Udate

printing/nt_printing.c:
set_driver_init_2()            Bind saved driver init info to new printer
set_driver_init()              
update_driver_init_2()         Save driver init info to new tdb key
update_driver_init()           
convert_driver_init()          Parse REG_BINARY data into DEVMODE
save_driver_init_2()           
save_driver_init()             Convert and save driver init info

rpc_parse/parse_spoolss.c:
spoolss_io_devmode()           Changed to non-static (see convert_driver_init)

rpc_server/srv_spoolss_nt.c
spoolss_addprinterex_level_2() Bind appropriate driver init info
_spoolss_setprinterdata()      Save driver init info on 'magic key' set

Now for the port to 2.2

JohnR


Revisions:
parse_spoolss.c		1.81.2.23 => 1.81.2.24
	http://www.samba.org/cgi-bin/cvsweb/samba/source/rpc_parse/parse_spoolss.c?r1=1.81.2.23&r2=1.81.2.24




More information about the samba-cvs mailing list