CVS update: samba/source/rpc_parse

[Jeremy Allison]

Jean Francois Micouleau wrote:
> 
> > The RPC code is currently littered with code that does init_uni_hdr() followed
> > immidiatly by init_unistr2(), and often the length argument is wrong.  (It was
> > for the code I changed, even before the charset stuff).  Another bug where we
> > made strings AT LEAST MAX_UNICODE_LEN long hid this bug.
> 
> your patch is wrong.
> 
> the header length is USUALLY (with some exceptions) the number of bytes
> and not the number of characters.
> 
> A UNISTR2 is not always NULL terminated. On some pipes and certains rpc
> functions, the string must be NON NULL terminated with uni_str_len being
> the length of the string and uni_max_len the length plus 1.
> 
> and btw, you're not checking if str and hdr ptrs are NON NULL before
> affecting values.

Andrew, can you roll back your patch please and pass it via
JF for correctlness checks before committing it again.

tridge and I are a little tied up right now so can't give
this the attention it deserves.

JF, can you ensure this gets fixed ?

Thanks,

	Jeremy.

-- 
--------------------------------------------------------
Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.
--------------------------------------------------------