CVS update: tng/source/lib

Elrond elrond at samba.org
Tue Jan 9 06:20:28 EST 2001


On Tue, Jan 09, 2001 at 12:06:12AM +1100, Luke Kenneth Casson Leighton wrote:
> that's not a good idea.
> 
> if this function gets used by NTLMv2, and the client sends the domain
> username over-wire in lower-case, and then the HMAC-MD5 calculation of the
> challenge-response is based on the upper-case version, you're screwed.

Unlikely.

parse_domain_user() parses a string of the form

	domain (lp_winbind_separator()) user

into

	DOMAIN
	user

I have to admit, that the function name is not realy nice.
It should include something about winbind. (hint)

And in tng (don't know about APPLIANCE_TNG) it is only used
in nsswitch/ (aka winbind).

I don't know, if the uppercasing is realy needed by
winbind.


    Elrond

> 
> 
> On Sat, 6 Jan 2001, Elrond wrote:
> 
> > 
> > Date:	Saturday January 6, 2001 @ 17:29
> > Author:	elrond
> > 
> > Update of /home/cvsroot/dcerpc/tng/source/lib
> > In directory angua:/tmp/cvs-serv3283/lib
> > 
> > Modified Files:
> > 	util_str.c 
> > Log Message:
> > Merge from SAMBA_TNG-branch on samba.org:
> > strupper(domain) in parse_domain_user().
> > 
> > 
> > 
> > 
> 
> 




More information about the samba-cvs mailing list