CVS update: samba/source/rpcclient

Tim Potter tpot at samba.org
Sun Dec 23 13:11:56 EST 2001


On Fri, Dec 21, 2001 at 02:18:07PM -0800, jfm at samba.org wrote:

> Log Message:
> close some handles. not really necessary but doesn't hurt.

But what happens if the handles aren't initialised?  If you fall out of
the function at line 116 then both connect_pol and domain_pol will be
uninitialised and you will be sending random data to the cli_samr_close()
function.

I was on a quest to close all open handles a while ago and had lots of
little booleans around called got_domain_pol which were set when the
policy handle was sucessfully opened.  In the end I decided it was
stupid and just deleted it all.  (-:


Tim.




More information about the samba-cvs mailing list