CVS update: samba/source/rpc_parse

jfm at samba.org jfm at samba.org
Sat Dec 22 09:34:49 EST 2001


Date:	Fri Dec 21 14:34:49 2001
Author:	jfm

Update of /data/cvs/samba/source/rpc_parse
In directory va:/tmp/cvs-serv11177/rpc_parse

Modified Files:
	parse_samr.c 
Log Message:
doesn't keep track of the struct's size we enumerate. W2K doesn't
calculate them and always reply a size of 32 bytes whereas NT4 did the
maths. Anyway, it looks like the clients don't complain.

in query_dom_info() at level 2, return the real number of users and
groups. That's the fix to the W95/98 userlist bug !

as W95/98 does a query_dom_info(2) followed by a query_disp_info(4) on
the SAME context handle (err we call it an lsa policy handle ! plain  
wrong name), I was tempted to keep the snapshoot in memory, to prevent
2 full user db enumerations in a row and just have one shared. But if some
client does the 2 calls on two different handles, we would have 2 copies  
in memory not free'ed before the samr_close().

We still have too many fixed constant and too many magic values in that
code. And btw, I really hates how the sequence number is generated !   

        J.F.




Revisions:
parse_samr.c		1.138 => 1.139
	http://www.samba.org/cgi-bin/cvsweb/samba/source/rpc_parse/parse_samr.c?r1=1.138&r2=1.139




More information about the samba-cvs mailing list