CVS update: samba/source/rpc_server
Jean Francois Micouleau
Jean-Francois.Micouleau at dalalu.fr
Tue Aug 28 05:52:53 EST 2001
On Tue, 28 Aug 2001, Andrew Bartlett wrote:
> > yep looks fine. should also check if the name ends with a '$' (just in
> > case).
>
> I would prefer not too, as the name ending in $ but not asking for a
> machine account would certainly be a bug, and would show up bugs in
> other parts of samba. Magic checks like that don't give me a 'warm
> fuzzy feeling'. I'm removing the one in reply.c shortly.
no you shouldn't ! You should log a message that a client is doing
something strange. It's not a magic check, it's a rule of thumb.
J.F.
More information about the samba-cvs
mailing list