CVS update: samba/source/rpc_server

[Andrew Bartlett]

Jean Francois Micouleau wrote:
> 
> On Mon, 27 Aug 2001, Andrew Bartlett wrote:
> 
> > Whats the chance of this being made clear in the code?  Like where it
> > says 'mach_acct' and '/* find machine account ...' and '/* machine
> > account exists: say so */'?  It makes it a little hard for mear mortals
> > like myself.
> 
> the day all the SAM RPCs will be documented ? I discovered by pure hazard
> and guess work it was the same call. I'm really sorry to not have added a
> comment saying so. But usually when it's 4AM and you ran out of you
> favorite drink several hours before and found such a thing, what do you do
> ? You commit a comment or go to bed ?
> 
> > Fortunetly the fix is trivial, and a proposed patch is attached.  I'll
> > test and commit it once the tree starts building again, unless there are
> > any objections.
> 
> yep looks fine. should also check if the name ends with a '$' (just in
> case).

I would prefer not too, as the name ending in $ but not asking for a
machine account would certainly be a bug, and would show up bugs in
other parts of samba.  Magic checks like that don't give me a 'warm
fuzzy feeling'.  I'm removing the one in reply.c shortly.

Andrew

-- 
Andrew Bartlett
abartlet at pcug.org.au
abartlet at samba.org