CVS update: samba/source/rpc_server

[Andrew Bartlett]

Andrew Bartlett wrote:
> 
> Simo Sorce wrote:
> >
> > Date:   Sat Aug 11 09:34:11 2001
> > Author: idra
> >
> > Update of /data/cvs/samba/source/rpc_server
> > In directory va:/tmp/cvs-serv12251/rpc_server
> >
> > Modified Files:
> >         srv_netlog_nt.c
> > Log Message:
> >
> > Without this become_root()/unbecome_root() pair I was not able to login
> > when samba acting as a PDC.
> > I also removed a pdb_free_sam(sampass), because it sampass was never
> > initialized before...
> >
> > Please abartlet can you check this patch is ok?
> > I feel like this was a bad check-in
> 
> Thats fine, I knew I would miss somthing :-)
> 
> I'll do some more checking of the RPC side of things.

On second thought, and having woken up properly, the
become_root()/unbecome_root() stuff is wrong.  We should do that
*inside* the auth code, where we need to access priviaged files.  Having
to get this right in the 5 or so different places that call the code is
just asking for trouble, best to place it inside the interface.

Now just to find where we are missing the
become_root()/unbecome_root()...

The pdb_free_sam(sampass) stuff is of corse fine, nice spotting.

Andrew Bartlett

-- 
Andrew Bartlett
abartlet at pcug.org.au
abartlet at samba.org