CVS update: samba/source/locking
Herb Lewis
herb at samba.org
Wed May 10 10:05:27 EST 2000
Date: Wednesday May 10, 2000 @ 10:05
Author: herb
Update of /data/cvs/samba/source/locking
In directory samba:/tmp/cvs-serv23350/locking
Modified Files:
brlock.c locking.c posix.c
Log Message:
Using a structure for a tdb key can lead to insideous, hard
to find bugs. On 64 bit IRIX, structure packing means that
a
struct {
SMB_DEV_T dev /* 4 bytes */
SMB_INO_T ino /* 8 bytes */
}
has 4 bytes of padding between the two members. If you
don't null the memory before using it as a tdb key,
you randomly can't find keys depending on what is in
the padding. This caused me immense pain and was hard
to track down.... :-)
Jeremy.
More information about the samba-cvs
mailing list