CVS update: samba/source/smbd

[Jeremy Allison]

Luke Kenneth Casson Leighton wrote:
> 
> not so.  take a look at smbd/lanman.c in api_NetWkstaGetInfo.  the info
> returned there is that which was obtained from a call to
> domain_client_validate() - namely the contents of the NET_USER_INFO_3
> structure.

But it's not used in general file/print serving, only in
returning domain logon info.

> well that can be fixed by #defining LSA_MAX_GROUPS to NGROUPS_MAX, then,
> can't it??

No, that sucks :-). It has to be dynamic (it is now :-).

> yeah, particularly as that's exactly what i have to construct, in
> se_access_check().

As you're only checking SIDs in se_access_check() can
you change the interface to take 3 parameters, a DOM_SID user
a number of groups followed by an array of DOM_SID groups.

That's what I changed the code to create.

> they were there because andrew specifically requested that anything like
> that be added, so it doesn't take him several hours to find, and yes, of
> course they need to be removed -- once

Already done :-).

> we don't have those calls available right now - and they should not be by
> name but by uid/gid -

I moved them into passdb/passdb.c - I agree they should be
by uid/gid, but that's an internal detail for the setup_user_sids()
function that I added.

Jeremy.

-- 
--------------------------------------------------------
Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.
--------------------------------------------------------