CVS update: samba/source/smbd

[Jeremy Allison]

Luke Leighton wrote:

> added a NET_USER_INFO_3 struct to user_struct.
> 
> register_vuid fills it with constructed info.

Luke,

	I really don't like this code. Call me please as I
intend to change it.

We don't want a full NET_USER_INFO_3 in the vuid structs,
as most of this info is never used in file/print serving
and is complete baggage.

It also takes *no* account of the fact that the UNIX group
list may be far larger than the available SID list in the
NET_USER_INFO_3 struct and will happily overwrite memory
*without checking*. This is *not* production code, a dynamic
array of SIDs is what should be used.

I'm also not pleased about the DEBUG(0,) calls that need
removing.

It also breaks the design of how smbd will be looking up
SIDs by doing a lookupsids(user_name) and lookupsids(group_name)
call to winbindd if it is running, and an internal mapping
if not. smbd/passwd.c is the wrong place to do this.

Jeremy.


-- 
--------------------------------------------------------
Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.
--------------------------------------------------------