CVS update: samba/source/lib

Gerald Carter gcarter at valinux.com
Thu Jul 20 04:28:17 EST 2000


Luke Kenneth Casson Leighton wrote:
> 
> i object.  if you want a list-associating "thing", use 
> a list.  in the cases where you want an 
> array-associating "thing" use an array.

Arrays, lists, .... I understand the difference, Luke.

> please do not just randomly replace occurrences of 
> code where an array is used because an array is 
> the optiml data structure to use.

Luke,  I'm am going to affense at this statement.
I do not randomly replace code.  That's all I'm 
going to say.

> the whole point of the array code is that you can 
> do this:
> 
> array[index]->structmember
> 
> and then you can free the entire array 
> _and_ the dynamically allocated pointers-to-array-items 
> with a single function call.

Fine.  Point taken.  I'm not arguing about lists vs. 
arrays.  I'm saying that the use of abusive use void 
pointers to functions in util_array, IMO, makes it 
nearly unreadable.  So if I can provide a better 
implementation of the same thing, why complain?






jerry




More information about the samba-cvs mailing list