CVS update: samba/source/lib
Jeremy Allison
jeremy at valinux.com
Tue Aug 15 09:39:28 EST 2000
On Mon, Aug 14, 2000 at 05:33:34PM +1000, Luke Leighton wrote:
> jeremy,
>
> please do not remove IS_BITS_SET_XXX macros just because you happen
> "not to like them". whilst still working on merging, you are not
> responsible for this code, therefore do not hinder its development
> whilst people are attempting to do merges. after the merge from
> TNG to cvs main is completed, you can do what the hell you like.
I didn't remove them because I "didn't like them", I removed
them because they were unclear and I couldn't tell what they
were trying to achieve.
When I examined them and the context they were being used, I
found that there were actually doing the incorrect thing under
some of the circumstances they were used. (ie. the IS_BITS_SET_ALL
macro was being used erroneously when IS_BITS_SET_SOME should have
been used).
If the author of these macros was not capable of using them correctly
I decided they were unsafe and so removed them. I will remove them
again if they have been re-added. (when I get back from LinuxWorld :-).
Jeremy.
More information about the samba-cvs
mailing list