CVS update: samba/source/client

Andrew Tridgell tridge at
Mon Mar 29 10:32:51 EST 1999

> Should I revert it, or it is ok to just leave it in?

I haven't looked at the change, if it's fairly small then leave it in
just so that other projects using our code can benefit. If it's big
and complex then we should take it out.

> I see; I had assumed it would always be used.  Sorry about that.

no problem. We only use it on a couple of platforms so far, and I'd
like to keep it that way if possible. 

> Assuming we have long long, yep, that's correct.  But if we don't,
> we'll overflow on 32bits.

you're right. I think we should change the variable to be of type
double. Probably we should make any variable that holds a sum of many
ints a double and use %.0f. That is simple and works on all systems.
I think that the only ones that will need doing are those used for
totals of files transferred, so there will be maybe 2 or 3 to change.

Cheers, Tridge

More information about the samba-cvs mailing list