CVS update: samba/source/client

Andrew Tridgell tridge at samba.org
Fri Mar 26 22:07:01 EST 1999


> > Don't use llu - some printf's don't support it.
> 
> It's for our snprintf only

I don't we want the long long support in our snprintf code. We don't
need it (we can use %.0f) and we certainly don't want #ifdef's all
over the place saying to use it if available.

We only want to use our snprintf code on systems where we really have
to. It is much better to use the native one if available. Our
vsnprintf code is known to have problems (which we are trying to track
down) and will add unnecessary baggage on systems that already have a
snprintf implementation.

I think the correct patch for dir_total is to use %.0f and cast to
double. It is portable and has plenty of bits.


More information about the samba-cvs mailing list