CVS update: samba/source/smbd

Jeremy Allison jallison at
Fri Jan 15 04:27:31 EST 1999

tridge at wrote:
> Date:   Thursday January 14, 1999 @ 14:07
> Author: tridge
> Update of /data/cvs/samba/source/smbd
> In directory samba:/tmp/cvs-serv25241
> Modified Files:
>       Tag: SAMBA_2_0
>         reply.c
> Log Message:
> fixed a missing IVAL in get_lock_offset(). There was no way that this
> code could have worked, so I'm a little suspicious of the testing that
> has been done on it!

Well I must confess I've been testing mainly on the 64
bit code - this was in the 'panic if we get a 64 bit call
in 32-bit mode'.

Also it was one of those "oh yeah, we can also map 64 bits->32
if I check that the top 32 bits are all 1's and discard them"
- but I fumbled the code :-).

"Well behaved" NT apps (are there any ?) wouldn't generate
such lock requests. Actually, MS-Office doesn't - that's what
I did the tests on.

Glad you caught it before release though :-).


Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.

More information about the samba-cvs mailing list