CVS update: samba/source/rpc_parse
Luke Kenneth Casson Leighton
lkcl at switchboard.net
Thu Apr 8 02:43:56 EST 1999
On Wed, 7 Apr 1999, Jeremy Allison wrote:
> Luke Kenneth Casson Leighton wrote:
> >
> > > (removed unneeded
> > > prs_align calls)
> >
> > uh oh. that's probably a bad idea. prs_align is more than likely there
> > for a good reason.
>
> Not when it causes a buffer overrun at the end of a
> packet.
really? then... is it _exactly_ at the end of the packet? remember that
nt4 sp2 and below don't do alignment at the very end.
and you should _always_ end up at exactly the end of the packet after
alignment after the last structure (except for nt4 sp2 and below).
> Remember I can tell when too much data is being
> read from an incoming RPC request now.
hm. you need to exclude the very last prs_align not all prs_aligns, then.
More information about the samba-cvs
mailing list