CVS update: samba/source

Andrew Tridgell tridge at samba.anu.edu.au
Mon Oct 5 13:09:52 EST 1998


> > added 64-bit file support
> 
> This broke wrapped.c on Solaris 2.6, because 64bit file support causes
> some names to be defined to other names.  My suggestion: split
> wrapped.c into wrapped.c and wrap64.c, and #undef _LARGEFILE_SOURCE
> and _FILE_OFFSET_BITS in the beginning of wrapped.c, before including
> any file.

I'd rather just not define _LARGEFILE_SOURCE at all and make explicit
calls to stat64(), lseek64() etc in system.c. That is how we have been
doing it up till now. I also do this in rsync and it works well.

_LARGEFILE_SOURCE and _FILE_OFFSET_BITS and just "convenience"
features to allow people to convert old code to 64 bit calls without
rewriting. For Samba I think we are better off having explict control.
Even more so given that smbwrapper redefines everything.

In fact, Jeremy already had what looks like appropriate stuff in
system.c, why wasn't it working for you?


More information about the samba-cvs mailing list