CVS update: samba/source/include

Jeremy Allison jallison at cthulhu.engr.sgi.com
Sat Nov 14 04:35:43 EST 1998


lkcl at samba.anu.edu.au wrote:
> 
> Date:   Saturday November 14, 1998 @ 4:26
> Author: lkcl
> 
> Update of /data/cvs/samba/source/include
> In directory samba:/tmp/cvs-serv24591/include
> 
> Modified Files:
>         smb.h
> Log Message:
> ZERO_STRUCTP does not check argument for NULL.
> ZERO_STRUCTPN _does_ check argument for NULL.

ARGGGHHHH !!! You've done it again !!!

ZERO_STRUCTP *SHOULD* check argument for NULL
because that's the way it's assumed in all of
the other code. 

Remember you are not the only user of this
macro.

It's used *everywhere*. You cannot change the
meaning of this without changing all the calls
to it !!!!!!!

I'm going to revert this.

Jeremy.

-- 
--------------------------------------------------------
Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.
--------------------------------------------------------


More information about the samba-cvs mailing list