CVS update: samba/source

Jeremy Allison jallison at
Wed May 6 03:14:17 EST 1998


	This code has a couple of problems, please fix asap 
as I cannot put this into 1.9.18p5 and release with this

I don't think you did a make proto; make clean; make
before committing this patch. If you do so you'll find
the build fails due to non-static functions from clitar.c
being included - you need to make these internal functions

Other problems : there are several functions in clitar.c
that are defined as non-void which have empty bodies
(the one that is obvious is skip_file()) - this is used
in the new code as ....

if .... !skip_file(finfo.size)

this is undefined as skip_file() is defined as :

static int skip_file(void)

As I need the main branch to compile in order to do
any work today, I will fix the static problems and
change these functions to return False/0 and re-check
in these changes - but please check these changes over 
and let me know when it's safe to release 1.9.18.

BTW: Always do a :

make proto
make clean

before doing any commits :-).



Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.

More information about the samba-cvs mailing list