CVS update: samba/source/include

[Jeremy Allison]

lkcl at samba.anu.edu.au wrote:

> 
>         generate_sam_sid() modified to take a domain name: it now
>         generates "DOMAIN_NAME.SID".  reasons:
> 
>         1) if you run multiple samba servers on the same machine
>         under different netbios names as members of a domain,
>         they won't all use the same SID, which is a _big_ mistake
>         but it would happen _by default_.
> 

No-one does this. To break backwards compatibility for this
unbelievably rare case is insane.

>         2) we have (had) a problem with sid_to_string() and string_to_sid()
>         which cause SIDs to be incorrectly read.  one of the major
>         reasons for *NOT* making this change was so as not to disrupt
>         existing users.  but as they will be anyway by this bug,
>         we might as well go ahead.
> 

Please put this back to MACHINE.SID for the backwards
compatibility reasons we have already covered....

Jeremy.

-- 
--------------------------------------------------------
Buying an operating system without source is like buying
a self-assembly Space Shuttle with no instructions.
--------------------------------------------------------