CVS update: samba/source

Andrew Tridgell tridge at samba.anu.edu.au
Tue Apr 21 16:40:14 EST 1998


> PLEASE REVIEW THIS CODE AND SUGGEST IMPROVEMENTS !!!!!!

Ok, two minor things:

1) you probably want v2 on line 127 not v1. Otherwise you aren't use
   the usec value!

2) use both the atime and modtime from the dates. On some filesystems
   atime is fixed.

3) if /etc/shadow exists then add in a checksum of its
   contents. Remember we primarily want a source of secret numbers,
   not random numbers. (the usec value is just a "secret" because it's
   hard to guess)

4) if the smbpasswd file exists then add in a hash of its contents. I
   know it won't exist in many cases, but when it does it is a great
   source of secrets.

Cheers, Andrew



More information about the samba-cvs mailing list