Apparent synchronization bug in rsync

[Kevin Korb]

The included github test case failed for me on vanilla rsync-3.2.7...

% ./test.sh
new.bin test.bin differ: byte 28345, line 1
% md5sum -b *.bin
7e11df4130968b5e4859f58b9bd6b453 *initial.bin
ff14ab080514d5681c99e4e1de01e29f *new.bin
151dd8b1c7bd628afcf38ac6c44155be *test.bin
% rsync --version
rsync  version 3.2.7  protocol version 31
Copyright (C) 1996-2022 by Andrew Tridgell, Wayne Davison, and others.
Web site: https://rsync.samba.org/
Capabilities:
     64-bit files, 64-bit inums, 32-bit timestamps, 64-bit long ints,
     socketpairs, symlinks, symtimes, hardlinks, hardlink-specials,
     hardlink-symlinks, no IPv6, atimes, batchfiles, inplace, append, ACLs,
     xattrs, optional secluded-args, iconv, prealloc, stop-at, no crtimes
Optimizations:
     no SIMD-roll, no asm-roll, openssl-crypto, no asm-MD5
Checksum list:
     xxh128 xxh3 xxh64 (xxhash) md5 md4 sha1 none
Compress list:
     zstd lz4 zlibx zlib none
Daemon auth list:
     sha512 sha256 sha1 md5 md4

rsync comes with ABSOLUTELY NO WARRANTY.  This is free software, and you
are welcome to redistribute it under certain conditions.  See the GNU
General Public Licence for details.


On 12/9/22 00:02, Wayne Davison wrote:
> On Thu, Dec 8, 2022 at 12:49 PM Kevin Korb wrote:
> 
>     The first "Bug Fix" listed in
>     https://rsync.samba.org/ftp/rsync/NEWS#3.2.4
>     <https://rsync.samba.org/ftp/rsync/NEWS#3.2.4> is almost certainly
>     related.  Apparently it was fixed via remote option but since your
>     test doesn't include networking that fix wouldn't help.
> 
> 
> No, the bug was fixed in 3.2.4 and it included an extra feature that 
> allows rsync to bypass the bug in an older remote rsync that still has 
> the bug.
> 
> On 12/8/22 15:03, Mark Raymond wrote:
> 
>     This looks like a bug to me; am I missing something? If it is a bug,
>     I'm  happy to create an issue in GitHub.
> 
> 
> I have managed to get a test case that fails.  If you want to also 
> supply one, feel free.
> 
> ..wayne..

-- 
~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,
	Kevin Korb			Phone:    (407) 252-6853
	Systems Administrator		Internet:
	FutureQuest, Inc.		Kevin at FutureQuest.net  (work)
	Orlando, Florida		kmk at sanitarium.net (personal)
	Web page:			https://sanitarium.net/
	PGP public key available on web site.
~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,-*~'`^`'~*-,._.,