strange crash with md5p8.diff + xxhash

[Wayne Davison]

On Sun, Sep 27, 2020 at 9:01 AM Madhu via rsync <rsync at lists.samba.org>
wrote:

> Turns out the comment in rsync.h: (struct name_num_obj):
>         struct name_num_item list[8]; /* A big-enough len (we'll get a
> compile error if it is ever too small) */
>
> isn't correct. I don't get a compile error.


Gcc likes to generate just a warning, not an error, which is enough for me
to notice the issue and fix it.  However, it would be nice if it was an
actual error, so I'm tweaking configure.ac to specify -pedantic-errors
(sometimes followed by --Wno-pedantic) for gcc, which seems to turn it into
an error just fine.  I've also expanded the array a bit.

..wayne..
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.samba.org/pipermail/rsync/attachments/20200929/cc890d87/attachment.htm>