[Bug 12769] error allocating core memory buffers (code 22) depending on source file system

samba-bugs at samba.org samba-bugs at samba.org
Wed Jun 24 11:44:04 UTC 2020


--- Comment #10 from MulticoreNOP <multicorenop at mailbox.org> ---
(In reply to Simon Matter from comment #7)
#define MALLOC_MAX 0x100000000

is greater than uint32-MAX, therefore will overflow and result in an
unpredictable and unfriendly manner.

#define MALLOC_MAX 0xD09DC300
(~3,5GiB) leaves some space to detect a "just too big for this implementation"
and will fail gracefully.

Yet, the real culprit here is the use of "unsigned int" as opposed to size_t.

I therefore propose the attached patch that removes MALLOC_MAX in its entirety
and should allow arrays as big as available virtual memory can support.

You are receiving this mail because:
You are the QA Contact for the bug.

More information about the rsync mailing list