[Bug 14126] The atomic-rsync script can exit 0 when the operation failed.

samba-bugs at samba.org samba-bugs at samba.org
Tue Sep 17 22:55:05 UTC 2019


https://bugzilla.samba.org/show_bug.cgi?id=14126

--- Comment #2 from Chris Brannon <cmb at prgmr.com> ---
(In reply to Paul Slootman from comment #1)
That was, in fact, my first try.
exit $? >> 8 is recommended for Perl by some sources on the net.  However, if
the called program gets a signal, "exit $? >> 8" would cause
atomic-rsync to exit 0, which is also not the right thing.

There are other correct solutions to this problem, but I think the simplest and
most expedient is exit 1, especially given that atomic-rsync has been exiting 0
under failure conditions.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.



More information about the rsync mailing list