preallocate working incorrectly in 3.1.3

TR Reardon trr2104 at columbia.edu
Thu Jan 17 00:14:46 UTC 2019


Just for clarity: the intention is still a logical-OR rather than
bitwise-OR?  If it's a new file on receiver, 'inplace' would still be
set and this KEEP_SIZE would be lost?


On Tue, Jan 15, 2019 at 12:06 PM Wayne Davison <wayne at opencoder.net> wrote:
>
> On Mon, Jan 14, 2019 at 6:11 PM TR Reardon via rsync <rsync at lists.samba.org> wrote:
>>
>> I believe that the changes to support --preallocate and --sparse together have broken --preallocate by itself (commit f3873b3d88b61167b106e7b9227a20147f8f6197)
>
>
> Indeed, those "opts" values were reversed, and thus fallocate wasn't told to keep the size 0.  I've checked in a fix.
>
> ..wayne..




More information about the rsync mailing list