[Bug 13445] Fuzzy searching in link-dest tries to open regular file as directory

samba-bugs at samba.org samba-bugs at samba.org
Sat May 19 16:20:56 UTC 2018


--- Comment #2 from Ben RUBSON <ben.rubson at gmail.com> ---
Nice catch, I was able to easily reproduce this issue just creating a directory
with the name of a just-deleted file.

The path you mention Einhard seems to be the only one where no check is done to
be sure a directory is given to send_directory().

I think it would however be better to explicitly tells send_directory() that
fbuf could not be a directory.

Perhaps creating a new FLAG_PERHAPS_NOTDIR flag ?
recv_generator() would add FLAG_PERHAPS_NOTDIR to GDL_IGNORE_FILTER_RULES in
its get_dirlist() call, get_dirlist() would then send this flag to
send_directory(), and send_directory() would properly return if fbuf is not a
directory and (flags & FLAG_PERHAPS_NOTDIR).

You are receiving this mail because:
You are the QA Contact for the bug.

More information about the rsync mailing list