[Bug 13433] out_of_memory in receive_sums on large files

samba-bugs at samba.org samba-bugs at samba.org
Wed May 16 23:07:26 UTC 2018


https://bugzilla.samba.org/show_bug.cgi?id=13433

--- Comment #2 from Kevin Day <toasty at dragondata.com> ---
(In reply to Dave Gordon from comment #1)

It looks like that's no longer allowed?

rsync: --block-size=10485760 is too large (max: 131072)
rsync error: syntax or usage error (code 1) at main.c(1591) [client=3.1.3]


#define MAX_BLOCK_SIZE ((int32)1 << 17)

        if (block_size > MAX_BLOCK_SIZE) {
                snprintf(err_buf, sizeof err_buf,
                         "--block-size=%lu is too large (max: %u)\n",
block_size, MAX_BLOCK_SIZE);
                return 0;
        }

OLD_MAX_BLOCK_SIZE is defined, but options.c would need to be patched to allow
looser block sizes if protocol_version < 30

-- 
You are receiving this mail because:
You are the QA Contact for the bug.



More information about the rsync mailing list