[Bug 13317] rsync returns success when target filesystem is full

[samba-bugs at samba.org]

https://bugzilla.samba.org/show_bug.cgi?id=13317

--- Comment #27 from Carson Gaspar <carson at taltos.org> ---
(In reply to Dave Gordon from comment #23)
Reading this, I took a look at the rsync sources, and, indeed, rsync has a bug.

perform_io() does not correctly check the return code from write().
safe_write() does - please steal the correct logic from it. perform_io() only
checks for write returning <=0, not for write returning something != len. So in
the case of a partial write() it will corrupt the destination file.

I haven't looked for additional coding errors of this type.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.