[Bug 13320] file contents cause rsync to fail (with certains args and dir structure)
samba-bugs at samba.org
samba-bugs at samba.org
Mon Mar 5 17:37:54 UTC 2018
https://bugzilla.samba.org/show_bug.cgi?id=13320
--- Comment #3 from Dave Gordon <dg32768 at zoho.eu> ---
Problem introduced by
commit f3873b3d88b61167b106e7b9227a20147f8f6197
Author: Wayne Davison <wayned at samba.org>
Date: Mon Oct 10 11:49:50 2016 -0700
Support --sparse combined with --preallocate or --inplace.
The new code tries to punch holes in the destination file using newer
Linux fallocate features. It also supports a --whole-file + --sparse +
--inplace copy on any filesystem by truncating the destination file.
Root cause is that the new variable 'sparse_past_write' is not reset
when switching files, thus leading to miscalculation of the current
seek position in do_punch_hole().
Quick fix is to reset this variable to the current seek position on
each call to write_sparse() - probably not the most efficient fix,
but it seems to work.
.Dave.
--
You are receiving this mail because:
You are the QA Contact for the bug.
More information about the rsync
mailing list