Unfortunate results from fake-super

[Wayne Davison]

On Sat, Feb 3, 2018 at 5:20 AM, Dave Gordon via rsync <rsync at lists.samba.org
> wrote:

> [...fake-super symlink saved as a file...]

This results in the copy being world-writable.
>

Indeed. The file initially gets created as a mode-600 file, but the code
later tweaks the permissions to match the symlink, which is (as you note) a
bad thing.

My first reaction is to change the code in set_stat_xattr() (in xattrs.c)
from:

       if (fst.st_mode != mode)
               do_chmod(fname, mode);

to:

       if (fst.st_mode != mode && !S_ISLNK(file->mode))
               do_chmod(fname, mode);

..wayne..
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.samba.org/pipermail/rsync/attachments/20180204/36fa01ab/attachment.html>