Code inconsistency between release version and git in rsync-3.0.9

[Robin H. Johnson]

On Tue, Apr 04, 2017 at 11:12:11AM +0200, Michal Ruprich via rsync wrote:
> There are huge differences between source files in the version 3.0.9
> released as a tar.gz and source files in git. I  would assume that the
> released version would correspond to the version in git but with 3.0.9
> it is not like that. In 3.1.0 the released and git versions are more or
> less the same.
How did you construct this?

I can't reproduce your result. The only differences I see are the generated
files proto.h, rsync.1, and rsyncd.conf.5.

Here's my test steps, with the output of everything except the final diffstats
omitted.

$ cd /tmp
$ tar xvf .../rsync-3.0.9.tar.gz
$ tar xvf .../rsync-3.1.0.tar.gz
$ git clone --bare git://git.samba.org/rsync.git /tmp/rsync-git-bare/
$ GIT_DIR=/tmp/rsync-git-bare git worktree add /tmp/rsync-git-3.0.9 v3.0.9
$ GIT_DIR=/tmp/rsync-git-bare git worktree add /tmp/rsync-git-3.1.0 v3.1.0
$ diff -Nuar rsync-git-3.0.9/ rsync-3.0.9/ --exclude .git --exclude-from rsync-git-3.0.9/.gitignore >rsync-git__rsync-3.0.9.diff
$ diff -Nuar rsync-git-3.1.0/ rsync-3.1.0/ --exclude .git --exclude-from rsync-git-3.1.0/.gitignore >rsync-git__rsync-3.1.0.diff
$ diffstat <rsync-git__rsync-3.0.9.diff
 proto.h       |  405 ++++++
 rsync.1       | 3585 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 rsyncd.conf.5 |  864 +++++++++++++
 3 files changed, 4854 insertions(+)
$ diffstat <rsync-git__rsync-3.1.0.diff
 proto.h       |  422 ++++++
 rsync.1       | 3958 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 rsyncd.conf.5 | 1075 +++++++++++++++
 3 files changed, 5455 insertions(+)

-- 
Robin Hugh Johnson
Gentoo Linux: Dev, Infra Lead, Foundation Trustee & Treasurer
E-Mail   : robbat2 at gentoo.org
GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85
GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136