[Bug 12430] New: rsync daemon chooses wrong place for pathes containing space and the module name

[samba-bugs at samba.org]

https://bugzilla.samba.org/show_bug.cgi?id=12430

            Bug ID: 12430
           Summary: rsync daemon chooses wrong place for pathes containing
                    space and the module name
           Product: rsync
           Version: 3.1.1
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P5
         Component: core
          Assignee: wayned at samba.org
          Reporter: thimo.neubauer at cst.com
        QA Contact: rsync-qa at samba.org

When uploading our internal test data (which features a rich set of filenames
and paths) I've discovered that some files ended up in the wrong place. Here's
a reduced setup to reproduce the problem:

 - create directory /tmp/foo

 - create a minimal rsyncd.conf, e.g.

"""
use chroot = false
uid = thimo

[foo]

path = /tmp/foo
read only = false
"""

 - start rsyncd with "sudo rsync --daemon --no-detach --config=rsyncd.conf"

Now the testcase is to copy some file into arbitrary directories. As a working
case perform:

 - mkdir -p '/tmp/foo/c boo'
 - rsync '/etc/issue' 'rsync://localhost/foo/c boo/issue'
 - as expected a file '/tmp/foo/c boo/issue' will appear

Now if the module name (in this case "foo") appears after the space you can see
the bug:

 - mkdir -p '/tmp/foo/c foo'
 - rsync '/etc/issue' 'rsync://localhost/foo/c foo/issue'
 - contrary to the case above you'll notice that the file ended up in
'/tmp/foo/c' instead of '/tmp/foo/c foo/issue'

Quoting wasn't a problem in the first case, hence it shouldn't be one in the
second case

-- 
You are receiving this mail because:
You are the QA Contact for the bug.