[Bug 12173] New: memory leak around poptGetOptArg()

samba-bugs at samba.org samba-bugs at samba.org
Wed Aug 24 13:34:48 UTC 2016


            Bug ID: 12173
           Summary: memory leak around poptGetOptArg()
           Product: rsync
           Version: 3.0.6
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: core
          Assignee: wayned at samba.org
          Reporter: cielartisan at gmail.com
        QA Contact: rsync-qa at samba.org

Description of problem:
    In poptGetOptArg(), con->os->nextArg is set to be NULL, which means the
returned memory is out of popt management.
    We have to free it.

Version-Release number of selected component (if applicable):
    rsync 3.0.6
    (perhaps the latest version is also affected, according to the source code)

How reproducible:
    always, with "--chmod=u+x" flag

Steps to Reproduce:
    valgrind --tool=memcheck rsync --chmod=u+x

Actual results:
    valgrind indicates memory leak.

Expected results:
    no memory leak, at least no big ones.

Additional info:
    Carefully read, it looks like POPT_ARG_STRING values also have to be freed
(such as shell_cmd and logfile_name).
    But since they are global variables, they are represented as "still
    Further investigation is required for this side.

You are receiving this mail because:
You are the QA Contact for the bug.

More information about the rsync mailing list