[Bug 11668] incorrect/inconsistent behavior when --backup-dir is on a full filesystem

samba-bugs at samba.org samba-bugs at samba.org
Fri Apr 1 19:03:13 UTC 2016


--- Comment #1 from Jim Nelson <jnelson at archive.org> ---
I've investigated this problem and coded a patch, which I will attach after
posting this comment.  I also coded a test case for the test suite.

Using the test case and git bisect, I determined the problem was introduced in
this commit:

commit 21cddef2b460098f5289b9cdbd592bf8f0f9e759
Author: Wayne Davison <wayned at samba.org>
Date:   Sat Jan 3 12:00:02 2009 -0800

    Improved the backup code:
    - Backups do not interfere with an atomic update (when possible).
    - Backing up a file will remove a directory that is in the way
      and visa versa.
    - Unify the backup-dir and non-backup-dir code in backup.c.
    - Improved the backup tests a little bit.

It appears this 2009 patch was excluded from v3.0.9 but included in v3.1.0 and
onward, which explains why Andrew didn't see it until the later release.

The test case requires root (to mount a small file-based file system and fill
it to capacity).  It uses trap to unmount the fs in case of error and not leave
the system in a poor state.

My proposed patch is straightforward: if unable to make the backup, call

I'd very much like to see this bug fixed, so please let me know if there's
anything I can do to improve either patch for inclusion.

You are receiving this mail because:
You are the QA Contact for the bug.

More information about the rsync mailing list