[Bug 11369] New: obsoleted autoconf macros

samba-bugs at samba.org samba-bugs at samba.org
Sat Jun 27 23:25:28 MDT 2015


            Bug ID: 11369
           Summary: obsoleted autoconf macros
           Product: rsync
           Version: 3.1.1
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P5
         Component: core
          Assignee: wayned at samba.org
          Reporter: brant at gurganus.name
        QA Contact: rsync-qa at samba.org

There are a few autoconf macros in use deemed obsolete upstream with straight
forward alternatives. The autoscan tool can correct most of them, but there are
two that take a little bit of code analysis.

Most items are replacing AC_TRY_COMPILE with AC_COMPILE_IFELSE.

Of those taking a bit more code analysis, there is the assessment by the
autoconf developers that sufficient time has passed that you can assume the
signal return type. In other words, it's my understanding that instead of
having it return RETSIGTYPE and having autoconf determine the type, it can just
be void and remove the check. The defined token seems to only occur in rsync.c
and main.c.

The second item is AC_C_LONG_DOUBLE which is replaced by AC_TYPE_LONG_DOUBLE
and/or AC_TYPE_LONG_DOUBLE_WIDER. By their assessment, currently available
compilers do indeed have long double types without needing to check for them.
What may need checked is whether that long double type is wider than a double
using AC_TYPE_LONG_DOUBLE_WIDER. The libs/snprintf.c file is the only one
affected by the header definition currently in use.

You are receiving this mail because:
You are the QA Contact for the bug.

More information about the rsync mailing list