[Bug 10611] New: No error code returned when removing source file failed

samba-bugs at samba.org samba-bugs at samba.org
Fri May 16 02:28:34 MDT 2014


           Summary: No error code returned when removing source file
           Product: rsync
           Version: 3.1.1
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: P5
         Component: core
        AssignedTo: wayned at samba.org
        ReportedBy: peto2468 at hotmail.com
         QAContact: rsync-qa at samba.org

Created attachment 9945
  --> https://bugzilla.samba.org/attachment.cgi?id=9945
Patch for returning error 26, when removing source files failed.

When rsync is required to remove source files with --remove-source-files option
and source files where not removed (eg. due to missing write permission on
source dir), no error code is returned, only error message is logged:
rsync: sender failed to remove [file]: Permission denied (13)

One would expect, that user is notified by special error code, that files were
tranferred succesfully, but source files were not removed as desired.

I created a small patch to fix this (see attachment).

Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

More information about the rsync mailing list