[Bug 10724] New: rsync 3.1.1 incorrectly creates extra dirs inside --backup-dir on Mac OSX

[samba-bugs at samba.org]

https://bugzilla.samba.org/show_bug.cgi?id=10724

           Summary: rsync 3.1.1 incorrectly creates extra dirs inside
                    --backup-dir on Mac OSX
           Product: rsync
           Version: 3.1.1
          Platform: x86
        OS/Version: Mac OS X
            Status: NEW
          Severity: normal
          Priority: P5
         Component: core
        AssignedTo: wayned at samba.org
        ReportedBy: chdiza at gmail.com
         QAContact: rsync-qa at samba.org


On MacOSX 10.9.4, new to rsync 3.1.1, I observe the incorrect creation of empty
dirs inside a --backup-dir.

To reproduce:

1. mkdir foo
2. mkdir bar
3. cd foo; touch fun
4. cd ..
5. rsync -trlvhp foo bar

Everything is as it should be: inside bar there is a clone of foo.  But now
continue (from the same working dir as from setp 5):

6. mkdir foo/newdir
7. cd foo; mv fun newdir; cd ..
8. rsync -trlvhpb --delete --backup-dir=mybackups --suffix=~ foo bar

Expected result: the directory bar should look like this:

bar/
bar/foo/
bar/foo/newdir/fun
bar/mybackups/
bar/mybackups/foo/
bar/mybackups/foo/fun~

Actual result: rsync 3.1.1 has created an empty dir "newdir" inside
mybackups.  That is, this is what bar looks like:

bar/
bar/foo/
bar/foo/newdir/fun
bar/mybackups/
bar/mybackups/foo/
bar/mybackups/foo/fun~
bar/mybackups/foo/newdir/

As you can see there is magically a "newdir" there.  It shouldn't be
there, because there never was a "newdir" inside bar/foo prior to step 8.
Therefore, there was no "newdir" there to be "backed up" into mybackups.

This behavior is new to 3.1.1 as best as I can tell.  I'm positive it never
occurred
on any prior version of rsync that I've ever used (2.6-ish?).

The above was just a toy example designed to illustrate the issue.  In
practice, rsync 3.1.1 left dozens of such "ghost" directories inside my
--backup-dir.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.