[Bug 10522] --detect-renamed patch is causing deletions as if a 'delete flag' was supplied, when none have been

[samba-bugs at samba.org]

https://bugzilla.samba.org/show_bug.cgi?id=10522

--- Comment #2 from J.R. <rsnc at opal.com> 2014-04-10 02:49:02 UTC ---
I can confirm this problem.

I suggest increasing the Severity of this bug to "Critical" because it causes
data to be lost without the user requesting this.

The problem is that a small section of code was lost from detect-renamed.diff
between 3.0.9 and 3.1.0:

--- delete.c.orig       2013-01-19 14:05:53.000000000 -0500
+++ delete.c    2014-04-09 22:35:59.000000000 -0400
@@ -153,6 +161,9 @@
                /* OK: try to delete the directory. */
        }

+       if (flags & DEL_NO_DELETIONS)
+               return DR_SUCCESS;
+
        if (!(flags & DEL_MAKE_ROOM) && max_delete >= 0 && stats.deleted_files
>= max_delete) {
                skipped_deletes++;
                return DR_AT_LIMIT;

Putting that back fixes this problem.

I will attach a complete detect-renamed.diff that includes this correction.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.