[Bug 9798] rsync crash with SIGSEGV when read time out happens

samba-bugs at samba.org samba-bugs at samba.org
Sun May 26 17:50:23 MDT 2013


Wayne Davison <wayned at samba.org> changed:

           What    |Removed                     |Added
             Status|NEW                         |ASSIGNED

--- Comment #3 from Wayne Davison <wayned at samba.org> 2013-05-26 23:50:21 UTC ---
(In reply to comment #2)
> I think rsync is not handling EILSEQ error returned by iconv(3).

No, but it did expect an E2BIG in preference to an EILSEQ, which might not be
the case.  I've fixed that in the latest git (for 3.1.0).

> Lets assume iconvbufs is returning EILSEQ continuously there are
> chances of "inbuf.len" wrapping again when inbuf.len reaches zero.

I would hope that iconv() would not return EILSEQ if inbuf.len was zero, but I
went ahead and made the code avoid the extra iconv() call if the input buffer
goes empty.

Thanks for sharing your thoughts -- the code should be a good bit safer now.

Can you test if the latest rsync fixes the crash for you?

Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

More information about the rsync mailing list