[Bug 8979] rsync daemon: High load while skipping hardlinks

[samba-bugs at samba.org]

https://bugzilla.samba.org/show_bug.cgi?id=8979

--- Comment #1 from Simon Klinkert <simon.klinkert at gmail.com> 2012-06-14 06:47:45 UTC ---
After some more investigation with gdb it seems like something is wrong in
function flist_for_ndx().

check_prior() calls flist_for_ndx() with ndx=759. The problem is he returns
every time cur_flist since there is no way to set another flist than cur_flist
(because ndx=759 and cur_flist->ndx_start = 758).

cur_flist: 
next = 0x81dfb18, prev = 0x87033d0, files = 0x88a34e0, sorted = 0x88a34e0,
file_pool = 0x81d1800, pool_boundary = 0x82bc474, used = 3, malloced = 32768,
low = 0, high = 2, ndx_start = 758, flist_num = 50, parent_ndx = 49,
in_progress = -2, to_redo = 0

I don't know if this would be the correct fix but maybe we need something like
this after the loops in flist_for_ndx:

if (ndx == flist->ndx_start - 1)
         return NULL;

I have three broken rsync daemons but I have no idea how to reproduce this
behavior.

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.