[Bug 8416] Please include systemd service file

[samba-bugs at samba.org]

https://bugzilla.samba.org/show_bug.cgi?id=8416

--- Comment #8 from michael+samba at stapelberg.de 2012-06-02 08:14:43 UTC ---
(In reply to comment #7)
> (In reply to comment #3)
> > There is a quirk to be aware of in this systemd unit.
> > 
> > Rsync areturns with non-zero (code 20) exit code when the running service is
> > stopped, so systemctl stop rsync.service will make the service to enter failed
> > state and not stopped state.
> > 
> > This is IMHO a bug in rsync when running as daemon. most if not all of other
> > daemons return 0 exity code on SIGTERM.
> 
> I say it's a bug in systemd that it doesn't allow for daemons to behave however
> they may happen to behave.
When I tell any daemon that it should stop, I expect it to exit with exit code
0 when it was stopped without any problems. In case there was an error while
stopping (say the disk is mounted read-only and some data cannot be written), I
expect it to return with an error code.

Therefore, I think rsyncd should be changed, not systemd :).

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.