[Bug 8445] New: rsync crash when remote filter rule changes

[samba-bugs at samba.org]

https://bugzilla.samba.org/show_bug.cgi?id=8445

           Summary: rsync crash when remote filter rule changes
           Product: rsync
           Version: 3.0.7
          Platform: x64
        OS/Version: Linux
            Status: NEW
          Severity: critical
          Priority: P5
         Component: core
        AssignedTo: wayned at samba.org
        ReportedBy: sweet_f_a at gmx.de
         QAContact: rsync-qa at samba.org


Hi,


I have setup a nightly backup pull via rsync like this:

$ rsync --version
rsync  version 3.0.7  protocol version 30
$ cd /backup/target
$ rsync  -axvSAHX  --delete --numeric-ids --relative --delete-excluded
--bwlimit=10000 --filter='. /backup/conf/filter_glaukos_home' 
root at glaukos:/exports/./data/   ./



Today noon I wondered why it's is still not ready.
After finding out that it was caused by a very large tmp dir of a user I told
him to fix his local .rsync-filter.

While rsync was still pulling from the guilty "tmp-2011-09-05/" he changed his
local filter from
...
+ /download*.xz
- /tmp
+ /tmp*.xz
...
to
...
+ /download*.xz
- /tmp*
+ /tmp*.xz
...

and moreover he deleted the whole directory "tmp-2011-09-05".

And rsync exited this way:

data/data-source/rolf/tmp-2011-09-05/99999_ICGE at wessa_2011-08-16.annot
data/data-source/rolf/tmp-2011-09-05/99999_ICGE at wessa_2011-08-16.rinse
file has vanished:
"/exports/data/data-source/rolf/tmp-2011-09-05/999_IUDMIIF at boe_2011-07-28.annot"
file has vanished:
"/exports/data/data-source/rolf/tmp-2011-09-05/999_IUDMIIF at boe_2011-07-28.rinse"
file has vanished:
"/exports/data/data-source/rolf/tmp-2011-09-05/999_IUDMIIF at boe_2011-07-29.annot"
file has vanished:
"/exports/data/data-source/rolf/tmp-2011-09-05/999_IUDMIIF at boe_2011-07-29.rinse"
file has vanished:
"/exports/data/data-source/rolf/tmp-2011-09-05/999_IUDMIIF at boe_2011-07-30.annot"
file has vanished:
"/exports/data/data-source/rolf/tmp-2011-09-05/999_IUDMIIF at boe_2011-07-30.rinse"
file has vanished:
"/exports/data/data-source/rolf/tmp-2011-09-05/999_IUDMIIF at boe_2011-07-31.annot"
file has vanished:
"/exports/data/data-source/rolf/tmp-2011-09-05/999_IUDMIIF at boe_2011-07-31.rinse"
file has vanished:
"/exports/data/data-source/rolf/tmp-2011-09-05/999_IUDMIIF at boe_2011-08-01.annot"
file has vanished:
"/exports/data/data-source/rolf/tmp-2011-09-05/999_IUDMIIF at boe_2011-08-01.rinse"
file has vanished:
"/exports/data/data-source/rolf/tmp-2011-09-05/999_IUDMIIF at boe_2011-08-04.annot"
file has vanished:
"/exports/data/data-source/rolf/tmp-2011-09-05/999_IUDMIIF at boe_2011-08-04.rinse"
file has vanished:
"/exports/data/data-source/rolf/tmp-2011-09-05/999_IUDMIIF at boe_2011-08-05.annot"
file has vanished:
"/exports/data/data-source/rolf/tmp-2011-09-05/999_IUDMIIF at boe_2011-08-05.rinse"
file has vanished:
"/exports/data/data-source/rolf/tmp-2011-09-05/999_IUDMIIF at boe_2011-08-06.annot"
file has vanished:
"/exports/data/data-source/rolf/tmp-2011-09-05/999_IUDMIIF at boe_2011-08-06.rinse"
file has vanished:
"/exports/data/data-source/rolf/tmp-2011-09-05/999_IUDMIIF at boe_2011-08-07.annot"
file has vanished:
"/exports/data/data-source/rolf/tmp-2011-09-05/999_IUDMIIF at boe_2011-08-07.rinse"
file has vanished:
"/exports/data/data-source/rolf/tmp-2011-09-05/999_IUDMIIF at boe_2011-08-08.annot"
file has vanished:
"/exports/data/data-source/rolf/tmp-2011-09-05/999_IUDMIIF at boe_2011-08-08.rinse"
file has vanished:
"/exports/data/data-source/rolf/tmp-2011-09-05/999_IUDMIIF at boe_2011-08-10.annot"
file has vanished:
"/exports/data/data-source/rolf/tmp-2011-09-05/999_IUDMIIF at boe_2011-08-10.rinse"
file has vanished:
"/exports/data/data-source/rolf/tmp-2011-09-05/999_IUDMIIF at boe_2011-08-11.annot"
file has vanished:
"/exports/data/data-source/rolf/tmp-2011-09-05/999_IUDMIIF at boe_2011-08-11.rinse"
file has vanished:
"/exports/data/data-source/rolf/tmp-2011-09-05/999_IUDMIIF at boe_2011-08-12.annot"
file has vanished:
"/exports/data/data-source/rolf/tmp-2011-09-05/999_IUDMIIF at boe_2011-08-12.rinse"
file has vanished:
"/exports/data/data-source/rolf/tmp-2011-09-05/999_IUDMIIF at boe_2011-08-18.annot"
file has vanished:
"/exports/data/data-source/rolf/tmp-2011-09-05/999_IUDMIIF at boe_2011-08-18.rinse"
file has vanished:
"/exports/data/data-source/rolf/tmp-2011-09-05/999_IUDMIIF at boe_2011-08-20.annot"
file has vanished:
"/exports/data/data-source/rolf/tmp-2011-09-05/999_IUDMIIF at boe_2011-08-20.rinse"
invalid modifier sequence at 't' in filter rule: -/tmp
rsync error: syntax or usage error (code 1) at exclude.c(829) [sender=3.0.7]
rsync: connection unexpectedly closed (130345973884 bytes received so far)
[receiver]
rsync error: error in rsync protocol data stream (code 12) at io.c(601)
[receiver=3.0.7]
rsync: writefd_unbuffered failed to write 5 bytes to socket [generator]: Broken
pipe (32)
rsync error: error in rsync protocol data stream (code 12) at io.c(1530)
[generator=3.0.7]
----------------------------------------------------------------------------
rsnapshot encountered an error! The program was invoked with these options:
/usr/bin/rsnapshot -c /backup/conf/rsnapshot_glaukos_home_data.conf sync
----------------------------------------------------------------------------
ERROR: /usr/bin/rsync returned 12 while processing
root at glaukos:/exports/./data/



This is IMO a very critical issue, since users may crash my backup every day.


cu,
Rudi

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.