[Bug 8020] --acls does not honor --numeric-ids if UIDs do not match

samba-bugs at samba.org samba-bugs at samba.org
Fri Mar 18 03:22:58 MDT 2011


https://bugzilla.samba.org/show_bug.cgi?id=8020

--- Comment #2 from Curu Wong <prinbra at gmail.com> 2011-03-18 09:22:58 UTC ---
Comment on attachment 6303
  --> https://bugzilla.samba.org/attachment.cgi?id=6303
rsync ACL numeric-ids option patch

diff -ru rsync-3.0.7.orig/acls.c rsync-3.0.7/acls.c
--- rsync-3.0.7.orig/acls.c    2011-03-18 16:33:10.000000000 +0800
+++ rsync-3.0.7/acls.c    2011-03-18 16:37:10.000000000 +0800
@@ -696,10 +696,14 @@
         uint32 access = recv_acl_access(&has_name, f);

         if (has_name) {
+            id_t id_orig = id;
             if (access & NAME_IS_USER)
                 id = recv_user_name(f, id);
             else
                 id = recv_group_name(f, id, NULL);
+            //don't map uid/gid when --numeric-ids option is set
+            if (numeric_ids)
+                id = id_orig;
         } else if (access & NAME_IS_USER) {
             if (inc_recurse && am_root && !numeric_ids)
                 id = match_uid(id);

-- 
Configure bugmail: https://bugzilla.samba.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.


More information about the rsync mailing list